Closed
Conversation
Add gitattributes file
…ept different casing
Add phpcs, phpstan, phpmd
Add auto-assign action
…overs notation is sufficient
Remove beStrictAboutCoversAnnotation from phpunit.xml.
Revert "Remove beStrictAboutCoversAnnotation from phpunit.xml."
The regular @Covers notation is sufficient
Remove trailing slash phpunit.xml.dist
Remove beStrictAboutCoversAnnotation from phpunit.xml.
Add requirements matrix for tests
Member
|
For all changes in the standard repository files; can you also send a PR to the skeleton package? |
bram123
requested changes
May 21, 2025
…rds (#55) * update editor config, gitattributes and phpcs to match company standards, add some rules to phpmd
# Conflicts: # .editorconfig # .gitattributes # .github/workflows/test.yml # .gitignore # README.md # composer.json # phpfci.xml # phpstan.neon # renovate.json
# Conflicts: # .editorconfig # composer.json # phpcs.xml.dist
# Conflicts: # .editorconfig # composer.json # phpcs.xml.dist
bram123
requested changes
May 21, 2025
* Apply editor config to project
# Conflicts: # .github/workflows/test.yml # composer.json # phpstan.neon
# Conflicts: # .github/workflows/test.yml # composer.json
There was a problem hiding this comment.
Pull Request Overview
Initial setup of the Digitalrevolution IPP library, providing core enums, entities, and project configuration.
- Introduces enums for IPP operations, tags, attribute types, and file formats.
- Implements domain entities for server, printer, print file, and response parsing.
- Configures static analysis, coding standards, CI workflows, composer metadata, and README documentation.
Reviewed Changes
Copilot reviewed 50 out of 50 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Enum/IppOperationTagEnum.php | Add enum for IPP operation tag values |
| src/Enum/IppOperationEnum.php | Define the full set of IPP operation codes |
| src/Enum/IppAttributeTypeEnum.php | Add enum representing IPP attribute categories |
| src/Enum/FileTypeEnum.php | Add enum for supported print file types |
| src/Entity/Response/IppResponseInterface.php | Define the base response interface |
| src/Entity/Response/CupsIppResponse.php | Implement parsing logic for CUPS IPP responses |
| src/Entity/IppServer.php | Add server configuration entity with setters/getters |
| src/Entity/IppPrinter.php | Add printer configuration entity |
| src/Entity/IppPrintFile.php | Add print file entity, attribute grouping logic |
| phpstan.neon | Include tests directory in analysis paths |
| phpfci.xml | Update coverage threshold attribute formatting |
| phpcs.xml | Lower cognitive complexity thresholds |
| composer.json | Update package name, dependencies, scripts, autoload |
| README.md | Document installation, usage examples, contributing |
| .github/workflows/test.yml | Refine CI matrix versions and test commands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.